urgent fixes
Guide for urgent fixes
🚨 Urgent Fixes & Pending Tasks
Date: 2026-01-10
Status: Heavy Bug Fixing / stabilization
🛑 Critical Compilation Errors (Blockers)
- Guard Captain Shop (
src/systems/ui/guard_captain_shop.rs)- Error:
cannot move out of dereference of ... shop_state.selected_item - Location: Line 120 (approx)
- Fix: Change
if let Some(_item_id) = shop_state.selected_itemtoif let Some(_item_id) = &shop_state.selected_item(borrow instead of move).
- Error:
- Magic / Projectile System (
src/systems/magic/projectile.rs)- Status: User active in file.
- Check: Verify
DamageDealtEventstruct signature matches the instantiation (fieldsattacker,target,damageare present;interaction_typewas removed). - Action: Ensure
systems/combat/mod.rsevent definition aligns with this usage.
- Editor Input (
src/systems/editor/input.rs)- Status: Recent changes to
snap_rotandhistoryresource. - Action: Verify if
EditorHistoryresource is properly initialized inEditorPlugin.
- Status: Recent changes to
⚠️ High Priority Warnings (Cleanup)
Run
cargo check to surface these:- Map System (
src/systems/map.rs):mut materialsparam does not need to be mutable. - Milestone Notifications (
src/systems/ui/milestone_notifications.rs): Unusedmut ui_offset, unusedanimation_timer. - Progression Tracker (
src/systems/ui/progression_tracker.rs): Unusedbuttonvariable.
🏗️ Pending Features & Next Steps
1. Grand Bazaar (Economy)
- Core Logic: Matching engine, OrderBook, TradeHistory.
- In-Game UI: Basic "Counter" interface.
- Web Integration:
- Connect
api.rsendpoints to actual Web Server (Axum/Actix). - Implement auth bridge for web users.
- Connect
- Visual Polish: Add 3D models or icons to the Trade Desk UI.
2. Editor & Building System
- Snapping: Refine
snap_rotlogic ininput.rs. - History: Ensure Undo/Redo (
EditorHistory) is fully functional.
3. Magic System
- Projectile Visuals: Replace default Sphere mesh with actual VFX scene/particles.
- Collision: Ensure
projectile_collision(or movement-based hit check) handles terrain/obstacles, not just target distance.
📝 General Todo
- Run
cargo clippy --all-targetsand fix remaining lints. - Check
tutorial_area_todo.mdfor specific level design tasks.